]> dgit.raspbian.org Git - gnome-shell.git/commit
portalHelper: Schedule recheck if it's too soon to recheck
authorMichael Catanzaro <mcatanzaro@redhat.com>
Sun, 27 Jul 2025 14:40:51 +0000 (16:40 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Sat, 13 Sep 2025 16:54:43 +0000 (18:54 +0200)
commitac442b13dda235a4b05e2cca9a72dbe368beccb2
tree87455900a8de4d849f6bb5ad03911e4da014391d
parentf6133f83cb0b5eae895544d8789e55c5e55cbf84
portalHelper: Schedule recheck if it's too soon to recheck

Currently we have a 30 second limit on rechecks. A recheck that would
violate the limit is simply dropped. This causes the portal helper to
never close itself.

Instead, schedule a future recheck for as soon as the timeout expires.
This will put an upper bound on how long the portal helper will
unnecessarily remain open.

(I've also changed the logic to unconditionally emit CANCELLED in
vfunc_close_request(), since this seems more correct. This won't
actually affect anything, because gnome-shell just ignores the
CANCELLED status, but in theory it's nice to end things with an
indication that we are finished. Otherwise, CANCELLED will never be
emitted.)

Closes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7790

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3813>
(cherry picked from commit f9c41ea665dc0dd175ba5933c867c4551c4acf95)
js/portalHelper/main.js